Skip to content

hal_rpi_pico: require GNU extensions for pico SDK #90939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

hal_rpi_pico: require GNU extensions for pico SDK #90939

wants to merge 1 commit into from

Conversation

dancollins
Copy link
Contributor

The pico SDK uses typeof() and the current approach, in CMakeLists.txt, wasn't enough. This commit adds a
dependency on GNU extensions to ensure the builds pass.

See #90936 for full details.

@dancollins
hal_rpi_pico: require GNU extensions for pico SDK
98d6180 
The pico SDK uses typeof() and the current approach, in
CMakeLists.txt, wasn't enough. This commit adds a
dependency on GNU extensions to ensure the builds pass.

Signed-off-by: Dan Collins <dan@collinsnz.com>
@github-actions github-actions bot added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Jun 2, 2025
@dancollins dancollins mentioned this pull request Jun 2, 2025
Draft
@josuah
Copy link
Collaborator

josuah commented Jun 2, 2025

Short brainstorming:

  • One way is to enable GNU extensions
  • One way is to enable C23
  • One way is this workaround:

    zephyr/arch/arm/include/cortex_m/cmse.h

    Lines 138 to 143 in cf6170c

    /* Required for C99 compilation (required for GCC-8.x version,
    * where typeof is used instead of __typeof__)
    */
    #ifndef typeof
    #define typeof __typeof__
    #endif

More reading:

Thank you!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@soburi
Copy link
Member

soburi commented Jun 2, 2025

zephyrproject-rtos/hal_rpi_pico#9
#90939
(And also reverting recent changes #90896)

This was discussed in the PR above, and unless there are any new issues that require a change in policy, we would like to proceed with the current situation.

Since pico-sdk requires gcc extensions or c24, we have no choice but to introduce this for the har_rpi_pico domain, but we would like to maintain c99 for the rest.

The current method is a bit hacky, but I think it's not bad from the perspective of achieving both of the above goals.

@dancollins
Copy link
Contributor Author

dancollins commented Jun 2, 2025 •
edited
Loading

I had searched for 'typeof' but didn't think to search for the C standard :) Thanks @josuah and @soburi.

Your approach, setting gnu11 for just the pico sources, is much less heavy-handed so I will close this.

@dancollins dancollins closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajf58 ajf58 Awaiting requested review from ajf58

@soburi soburi Awaiting requested review from soburi

@ThreeEights ThreeEights Awaiting requested review from ThreeEights

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@soburi soburi

Labels
platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancollins @josuah @soburi